Fix: Minor improvements to mapping symbol handling with dot suffix #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4lg
force-pushed
the
riscv-mapping-sym-dot-handling
branch
2 times, most recently
from
019e2d9 to
b3a9e9f
Compare
a4lg
force-pushed
the
riscv-mapping-sym-dot-handling
branch
from
b3a9e9f to
c7187ed
Compare
This commit makes minor improvements to mapping symbols (executable) handling with a dot suffix. 1. Use size_t instead of int 2. Allocate minimum size for the architectural string buffer. 3. memcpy instead of strncpy because we know the exact size to copy. 4. Minor variable naming changes. opcodes/ChangeLog: * riscv-dis.c (riscv_get_map_state): Minor improvements to handling of executable mapping symbols with dot suffix.
a4lg
force-pushed
the
riscv-mapping-sym-dot-handling
branch
from
c7187ed to
3bc9421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiki Page (details): https://github.com/a4lg/binutils-gdb/wiki/riscv_mapping_sym_dot_handling