fix: increase MAX_SUPPORTED_LOGS_NUMBER from 5 to 100 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proving logs is the least efficient thing Helios does now. We have a solution to this we will be shipping soon, but I am hesitant to change this value now. I do think it makes sense to make this value configurable though. Maybe we could add a |
|
@ncitron I've made some changes, jsut curious what are your thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change increases the maximum number of logs that can be fetched from 5 to 100.
The current limit is too restrictive for modern dApps that generate more logs during transactions.
It improves usability while maintaining reasonable performance.