Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash #45

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add flash #45

wants to merge 4 commits into from

Conversation

amorehead
Copy link
Collaborator

@amorehead amorehead commented Sep 26, 2023

  • Adds lightning-flash to poe tasks.
  • NOTE: We also need to update the README to describe that a manual installation of lightning-flash is in order, via either poe install-flash or pip install pytorch-lightning==1.9.5 && pip install lightning-flash --no-dependencies.

@amorehead
Copy link
Collaborator Author

amorehead commented Dec 29, 2023

@a-r-j, IIRC I originally proposed to install lightning-flash using pip install ... --no-dependencies instead of by listing it as a poetry dependency because it was raising errors when I tried to install it while including its dependencies. There seem to be some upstream conflicts between lightning 2.0 and lightning-flash that have yet to be addressed. It's possible these conflicts have been addressed with lightning 2.1.2+ and/or newer versions of lightning-flash. Feel free to try them out to see if they can be included in the poetry dependencies more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant