Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] add background download option for ios and RN Upgrade #127

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

a-ghorbani
Copy link
Owner

@a-ghorbani a-ghorbani commented Dec 3, 2024

Description

iOS background downloads (even if the app is in foreground) are pretty slow (about 10x slower in my tests).
We’re letting users choose:

  • Background Mode: Slower, but keeps going when the app is in the background.
  • Non-Background Mode: Faster, but stops if the app goes to the background.

Also, React Native has been updated to 0.76.3. - this should've been a separate pr

Fixes #9

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani a-ghorbani marked this pull request as ready for review December 3, 2024 21:25
@a-ghorbani a-ghorbani merged commit 01941c0 into main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ux] model download on background
1 participant