Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/avoiding keyboard settings #115

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Fix/avoiding keyboard settings #115

merged 4 commits into from
Nov 30, 2024

Conversation

a-ghorbani
Copy link
Owner

@a-ghorbani a-ghorbani commented Nov 30, 2024 •
edited
Loading

Description

The input fields in the model settings were not properly avoiding the keyboard.

  • Added a KeyboardAvoidingView in ModelsScreen.
  • Note: Multiline text input still does not support KeyboardAvoidingView (see: React Native issue #16826). To address this, implemented a workaround by scrolling to the height of the keyboard.

Fixes #41
Fixes #116

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani a-ghorbani marked this pull request as ready for review November 30, 2024 22:42
@a-ghorbani a-ghorbani merged commit b5afeca into main Nov 30, 2024
3 checks passed
@a-ghorbani a-ghorbani deleted the fix/avoiding-keyboard-settings branch November 30, 2024 22:50
@a-ghorbani a-ghorbani restored the fix/avoiding-keyboard-settings branch November 30, 2024 22:50
@a-ghorbani a-ghorbani deleted the fix/avoiding-keyboard-settings branch November 30, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@a-ghorbani