fix: add stop tokens that are in the chat template and remove tfs_z #113
+86
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When models are downloaded through Hugging Face search or loaded locally, the app currently infers stop words from the EOS token, but that’s not enough. EOT tokens also need to be included as stop words; otherwise, responses might contain those tokens.
This PR checks if any of these tokens:
are in the chat template and adds them to the stops array if found.
Also we remove
tfs_z
.Fixes #101
Platform Affected
Checklist