Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VideoClip.py #2161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update VideoClip.py #2161

wants to merge 1 commit into from

Conversation

TitanStar73
Copy link

Fixes bug where fps=None due to changes in python decorators
The bug arises when write_video is used. The ffmpeg's write operation fails due to fps=None.

  • [-] I have properly explained unusual or unexpected code in the comments around it

Fixes bug where fps=None due to changes in python decorators
@@ -362,6 +362,9 @@ def write_videofile(
name + Clip._TEMP_FILES_PREFIX + "wvf_snd.%s" % audio_ext,
)

if fps is None:
fps = fps.self

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be this?

Suggested change
fps = fps.self
fps = self.fps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants