-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ffmpeg_reader not selecting a default stream #2114
base: master
Are you sure you want to change the base?
Conversation
@bzczb Thanks for the submission – I don't have time to review its actual contents, but saw it didn't pass the formatting checks. Could you update the formatting? |
@keikoro formatting fixed. Can't get pre-commit setup in |
I would need a few tests added to show the proper working of this, the line 645 by itself make me doubt this work perfectly as intended. |
I need to remake this PR to match latest master. The line looks right to me, the intent is to select a default at the end instead of the middle, so the |
Oh, I missed the rewrite of return on parsing methods. I let you check what need to be updated for the new master and add some tests showing an example of this in work. Thanks a lot for your work ! |
added test to demonstrate some brokenness with .wmv |
fix #869 #899
ffmpeg, at least the version that's installed automatically with moviepy, sometimes comes up with no default stream for a given input file. This PR does nothing more than set a default stream automatically when none is specified, which is the cause of the missing "video_fps" issue.
Unfortunately I fixed this bug a long time ago in a working branch, and can't find the file that raised this problem in the first place. I think it was a ".wmv" or ".asf".