Fix: Solving the MUTED issue when using video-rtc.js & Added an "onplay" event triggered when playback starts#4639
Open
IgorA100 wants to merge 8 commits intoZoneMinder:masterfrom
Open
Fix: Solving the MUTED issue when using video-rtc.js & Added an "onplay" event triggered when playback starts#4639IgorA100 wants to merge 8 commits intoZoneMinder:masterfrom
IgorA100 wants to merge 8 commits intoZoneMinder:masterfrom
Conversation
…nitorStream.js) Due to desynchronization, for example, on the Watch page, after hiding and then re-displaying the page, muted mode spontaneously re-enables after 15 seconds. This is a temporary solution and requires further analysis.
IgorA100
changed the title
This will avoid a warning like `DOMException: The play() request was interrupted by a new load request.`
IgorA100
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using video-rtc.js (Go2RTC) on the Watch page, after hiding and then re-displaying the page, muted mode spontaneously re-enables after 15 seconds.
I decided to make a correction to video-rtc.js here, as this file had already been modified and differs from the original https://github.com/AlexxIT/go2rtc/blob/master/www/video-rtc.js
I also created a PR in the Go2RTC developer repository AlexxIT/go2rtc#2102
Adding the "onplay" event will allow for more flexible handling of the playback start event.