Feat: Using audio motion analyzer#4393
Conversation
|
Watch page Monitor page Will these names be ok or do I need to change something? |
|
I guess it's ok. I would have gone with a toggle for video and a toggle for analysis, but either way gets the job done. |
Yes, I wanted to do it that way. This is a multi select in which you can select the necessary players or disable them all. |
I've done a lot already, but... I came to the conclusion that Player = None is wrong. To play only audio, we still need a player. It can be either go2rtc or rtsp2web. |
|
Let's leave the player issues aside. I disagree with adding options to disable zms playback, as that is the fallback when all else fails. People get confused when there are too many options to configure. |
I don't want to disable ZMS either. |
…l the volume of all monitors Moving the volume slider control portion from MonitorStream.js to skin.js
- Clear IconMute when executing destroyVolumeSlider() - Added the ability to clear the icon state to changeStateIconMute() MonitorStream.js - Set #volumeControls to "disabled" instead of "hidden" - Don't execute controlMute() when executing createVolumeSlider() Added: audioMotionAnalyzer.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@connortechnology |
|
Isaac, have you checked this PR yet? |
|
@connortechnology |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@connortechnology |
|
Needs a little polish I think. Initially it was displaying no video, I suspect due to no value for What Display. Upon selecting there everything started to appear. I wonder if we should relocate the analyzer to a side column. We keep losing a lot of vertical space, which then reduces the width of the video. Instead of What Display, just say Display: or even Show: just because it's shorter. |
|
I have reverted this. We cannot include audiomotion.dev js file. It is GNU Affero licensed which is incompatible with our gplv2. THe end user will have to install it themselves. |
|
I'm not very familiar with the intricacies of the licensing system, but isn't it possible to incorporate AGPL-3.0-licensed code into GPLv2-licensed code without modification? |
|
I'm in complete shock. |
It's probably no longer necessary :( |
|
Isaac, I'm not sure you'll like this, but maybe I should rewrite the code so that if the file web/skins/classic/assets/audioMotion-analyzer/src/audioMotion-analyzer.js is missing, ZM will behave as it does now (without the additional UI selectors). If the user adds the file "audioMotion-analyzer.js," everything will work. |
|
@connortechnology |
|
@connortechnology |
|
Yes that is what you should do. Also make sure it doesn't break if the file isn't there |
|
Wow, Isaac, you're my savior! |
There are still some changes that need to be made to the BD:
ALTER TABLE `Monitors` ADD `WhatDisplay` enum('OnlyVideo','OnlyAudioVisualization','VideoAudioVisualization') NOT NULL DEFAULT 'OnlyVideo' AFTER `Decoding`;