This repository was archived by the owner on Aug 27, 2025. It is now read-only.
[master] Zil 5450 improvements to network and native tests #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
…de-of-tests-for-native-code-test-Node-test-Zilliqa
Steve-White-UK
commented
Oct 27, 2023
Contributor
Author
Steve-White-UK
left a comment
Steve-White-UK
left a comment
There was a problem hiding this comment.
Remember to review UnixDomainSocket class, this one kinda slipped through without notice.
bzawisto
previously approved these changes
Oct 30, 2023
Renamed branch to help ci
Steve-White-UK
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade of the test components to work using the native build of Zilliqa
a new test directory native exists which contains scripts to start zilliqa in native mode according to the definition of these scripts.
This environment is provided using the test directories
Node
Zilliqa
native
This PR also contains some small improvements made to the network layer, to gracefully close sockets and some better error messages indicating which ports are in use when a socket connection fails.
These tests currently work from unaltered constants_local,XML in the Zilliqa trunk.
scripts are as documented on the Zilliqa Read.me
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)