Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vespa-Backend: Finalize Project #19

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Vespa-Backend: Finalize Project #19

wants to merge 15 commits into from

Conversation

Tommymarvel
Copy link
Collaborator

@Tommymarvel Tommymarvel commented Feb 18, 2023

Vespa-Backend: Finalize Project

In this pull-request we did the followings:

  • Made sure to follow the layout of the provided design.
  • Implemented the followings features:
    • Core features - for teams of each size
      • The user logs in to the website, only by typing the username (a proper authenticated login is a requirement if your group is made of 5 people).
      • In the navigation panel, the user can see links to:
      • Motorcycles/doctors/classes/items that you selected as a theme.
      • "Reserve" form.
      • "My reservations".
      • "Add motorcycle/doctor/class/item that you selected as a theme" (the link is visible to everybody).
      • "Delete motorcycle/doctor/class/item that you selected as a theme" (the link is visible to everybody).
    • On the main page, the user can see a list of motorcycles/doctors/classes/items that you selected as a theme.
    • When the user selects a specific item, they can see the details page with its full description (skip the "Rotate image" button).
    • In the details page, the user can click the "Reserve" button (in the design you can see the "Configure" button - please replace it with the "Reserve" button).
    • When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.
    • Make the app responsive, creating both mobile and desktop versions.
  • Made sure to follow the list of best practices for Ruby.
  • Made sure that there are no linter errors.
  • Made sure that I used correct Gitflow.
  • Made sure that I documented your work in a professional way.

Vespa-Frontend-Repo


Note: This project has been evaluated and passed, also this team is a team of (2)

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The student comments in the PR that this project has been already evaluated and approved. As requested, reviewing normally.

note to student: Every comment in the review is intended to improve your project so you can showcase your new abilities to potential employers coming to your repo. Of course, everything is optional as this is a special kind of review.

Hi @Tommymarvel,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Some parts of the frontend design are impressive✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

I strongly recommend you take them into account as they can improve your final evaluation.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
app/controllers/motorcycles_controller.rb Outdated Show resolved Hide resolved
app/controllers/cities_controller.rb Outdated Show resolved Hide resolved
@ZikaZaki ZikaZaki requested a review from Meltrust February 19, 2023 02:53
@ZikaZaki
Copy link
Owner

Hey @Meltrust, I have implemented all the requested changes. Thanks again for your time and constructive feedback.

@ZikaZaki ZikaZaki changed the title Vespa App Vespa-Backend: Finalize Project Feb 19, 2023
Copy link

@Nemwel-Boniface Nemwel-Boniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Tommymarvel , @Sonickmumba , and @ZikaZaki 👋,

I am Nemwel your reviewer.

This is an additional review as a result of the second opinion request.

Because the requested changes are optional, we think your project can be approved.

Note However, I highly suggest that you should implement unit tests for your project.

As this was the only reason that your project was not approved it will be approved as soon as possible.
Please note that since we will approve it manually so this could take a few hours!

Keep rocking 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants