-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vespa-Backend: Finalize Project #19
base: main
Are you sure you want to change the base?
Conversation
Vespa-Backend: LatestModels
Add api documentations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: The student comments in the PR that this project has been already evaluated and approved. As requested, reviewing normally.
note to student: Every comment in the review is intended to improve your project so you can showcase your new abilities to potential employers coming to your repo. Of course, everything is optional as this is a special kind of review.
Hi @Tommymarvel,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Some parts of the frontend design are impressive✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
I strongly recommend you take them into account as they can improve your final evaluation.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
Hey @Meltrust, I have implemented all the requested changes. Thanks again for your time and constructive feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Tommymarvel , @Sonickmumba , and @ZikaZaki 👋,
I am Nemwel your reviewer.
This is an additional review as a result of the second opinion request.
Because the requested changes are optional, we think your project can be approved.
Note However, I highly suggest that you should implement unit tests for your project.
As this was the only reason that your project was not approved it will be approved as soon as possible.
Please note that since we will approve it manually so this could take a few hours!
Keep rocking 🚀!
Vespa-Backend: Finalize Project
In this pull-request we did the followings:
Vespa-Frontend-Repo
Note: This project has been evaluated and passed, also this team is a team of (2)