add cache entry metadata to event args #539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the events to include the cache entry metadata when possible.
The purpose is to let event subscribers have access to the metadata to take further actions based on attributes such as
LastModifiedTimestamporEagerExpirationTimestamp.To avoid breaking changes on the public API, I've kept the event delegates as they are and added new constructors to the event args classes where metadata were added.
New classes have been created when the events relied on the base event args. However, these are not part of the delegates as that would have resulted in breaking changes. It is still possible for the consumers to cast the received args to access the metadata property.