Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new test, 5 tests failed #370

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Added new test, 5 tests failed #370

merged 1 commit into from
Nov 17, 2023

Conversation

badumbatish
Copy link
Contributor

Hi there, this is the pull request for issue #298.

I added 14 lines of test to the CMakeLists.txt, reran the test. Same amount of tests failed as before I adjusted CMakeListst.txt

[----------] Global test environment tear-down
[==========] 269 tests from 37 test suites ran. (1218 ms total)
[  PASSED  ] 264 tests.
[  FAILED  ] 5 tests, listed below:
[  FAILED  ] DOTTest.ReadFromDotUndirected
[  FAILED  ] DOTTest.ReadFromDotUndirectedWeighted
[  FAILED  ] DOTTest.ReadFromDotDirected
[  FAILED  ] MTXTest.ReadFromMtxDirectedWeighted
[  FAILED  ] MTXTest.ReadFromMtxUndirectedWeighted

@ZigRazor , any adjustment i should make?

@github-actions github-actions bot added the test Something about test label Nov 13, 2023
@ghost
Copy link

ghost commented Nov 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@badumbatish
Copy link
Contributor Author

Fyi, I think the reason for me failing the test is the same as #351.

@ZigRazor
Copy link
Owner

Fyi, I think the reason for me failing the test is the same as #351.

Yes @badumbatish try to solve it, thank you!

@badumbatish
Copy link
Contributor Author

Fyi, I think the reason for me failing the test is the same as #351.

Yes @badumbatish try to solve it, thank you!

Sorry what i meant is I just called the test from the wrong directory, when called in the right directory everything passed

@ZigRazor
Copy link
Owner

OK

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e96085f) 97.52% compared to head (0955f8f) 97.50%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   97.52%   97.50%   -0.02%     
==========================================
  Files          55       55              
  Lines        9236     9236              
==========================================
- Hits         9007     9006       -1     
- Misses        229      230       +1     
Flag Coverage Δ
unittests 97.50% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZigRazor ZigRazor merged commit cf8c3e4 into ZigRazor:master Nov 17, 2023
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants