Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing output format of Kosaraju algorithm #365

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

guru2396
Copy link
Contributor

This PR is for #261.

  • Added new fields in SCCResult struct for saving the output as a map.
  • Modified Kosaraju algorithm to save output in the map.
  • Modified tests

@github-actions github-actions bot added test Something about test core something about core labels Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #365 (07635df) into master (92fca0a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   97.50%   97.50%   -0.01%     
==========================================
  Files          55       55              
  Lines        9179     9174       -5     
==========================================
- Hits         8950     8945       -5     
  Misses        229      229              
Flag Coverage Δ
unittests 97.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/CXXGraph/Graph/Graph.hpp 95.58% <100.00%> (ø)
include/CXXGraph/Utility/Typedef.hpp 100.00% <ø> (ø)
test/KosarajuTest.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ZigRazor ZigRazor requested review from ZigRazor, sbaldu and nrkramer and removed request for ZigRazor and sbaldu October 19, 2023 08:38
@sbaldu
Copy link
Collaborator

sbaldu commented Oct 19, 2023

Looks good

@ZigRazor ZigRazor merged commit a19c100 into ZigRazor:master Oct 19, 2023
24 of 28 checks passed
@ZigRazor ZigRazor linked an issue Oct 19, 2023 that may be closed by this pull request
@guru2396
Copy link
Contributor Author

One more thing to add. Instead of using edgeSet, the adjacency matrix can be used to populate the nodeSet in getNodeSet() method. This method is used many times in the code, so may be there can be some benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Type of Kosaraju Proposal
3 participants