Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fixes to base repo #1

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

ZeroByter
Copy link
Owner

I have been keeping an eye on this repo, and I like the changes!
I think you should merge these awesome fixes to my base repo to make it easier for everyone to utilize these changes and fixes.

@noamalffasy
Copy link

That would be a great idea!

I had actually thought of merging the fork but then I changed too many things, such as the formatting and updated the JS from ES5 to ES6.
Perhaps it could be an opportunity for adding style enforcement of some kind.

Another thing I think should be worked on before merging is tests.
Perhaps making a fake server could help, the server would test all cases such as choosing a folder, the source folder, uploading from IDE, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants