WCM-527: add content query fields print-volume, -year and -ressort #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wosc
requested changes
Nov 15, 2024
stollero
force-pushed
the
WCM-527-baukasten-volumes
branch
from
ba9569d
to
1e4d2b9
Compare
stollero
commented
Nov 15, 2024
| content_type = zope.schema.Choice( | ||
| title=_('Content type'), source=zeit.cms.content.sources.CMSContentTypeSource() | ||
| ) | ||
| print_ressort = zope.schema.Choice( |
There was a problem hiding this comment.
In Rücksprache mit Sonja wählen wir hier nun doch ein Textfeld um historische Daten zu unterstützen. Sonst würde die Dropdown Box automatisch auf den ersten Eintrag springen, wenn ein Wert unbekannt ist und eine Person was händisch an einer älteren Ausgabenseite macht (warum auch immer).
keep consistent naming for variables
reason: we need to support historical data and if we use a dropdown and somebody checks out a historical print volume the field jumps to the first entry changing the historical value to a wrong one
stollero
force-pushed
the
WCM-527-baukasten-volumes
branch
from
03e02a5
to
8f6e8e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
gif