Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCM-316: add teaser title, teaser text and background color to volume #846

Merged
merged 8 commits into from
Sep 17, 2024
Merged

WCM-316: add teaser title, teaser text and background color to volume #846

merged 8 commits into from
Sep 17, 2024

Conversation

Sinnaj94
Copy link
Contributor

@Sinnaj94 Sinnaj94 commented Sep 4, 2024 •
edited
Loading

In diesem Pull-Request wird das Ausgaben-Objekt durch folgende, optionale Attribute erweitert:

  • Teaser-Title
  • Teaser-Text
  • Hintergrundfarbe

Dabei wird die Hintergrundfarbe validiert.

Beschreibung des Sachverhaltes ist auch in Ticket WCM-308 beschrieben.

Hier die Dokumentation: https://github.com/ZeitOnline/vivi-deployment/pull/1136

Checklist

  • Documentation
  • Changelog
  • Tests
  • Translations

gif

@Sinnaj94 Sinnaj94 changed the title WCM-307: add teaser title, teaser text and background color to volume WCM-316: add teaser title, teaser text and background color to volume Sep 4, 2024
@Sinnaj94 Sinnaj94 force-pushed the WCM-316_add-teaser-attributes-to-volume branch from 02762ce to ba9cfc4 Compare September 4, 2024 10:01
wosc
wosc requested changes Sep 4, 2024
View reviewed changes
core/src/zeit/content/volume/volume.py Show resolved Hide resolved
core/src/zeit/content/volume/tests/test_volume.py Outdated Show resolved Hide resolved
@Sinnaj94 Sinnaj94 force-pushed the WCM-316_add-teaser-attributes-to-volume branch from 6f96c8d to 62a95ab Compare September 4, 2024 14:33
@Sinnaj94
Copy link
Contributor Author

Sinnaj94 commented Sep 5, 2024

Notiz für mich: In der Datenbank volume->properties->teaserText zu volume->properties->volume_note umbenennen 😄

@Sinnaj94 Sinnaj94 force-pushed the WCM-316_add-teaser-attributes-to-volume branch 2 times, most recently from 490e57b to 22ebee4 Compare September 9, 2024 08:27
@Sinnaj94 Sinnaj94 force-pushed the WCM-316_add-teaser-attributes-to-volume branch from 22ebee4 to 55fde5e Compare September 13, 2024 13:00
@Sinnaj94 Sinnaj94 requested review from wosc and removed request for wosc September 13, 2024 13:03
@Sinnaj94 Sinnaj94 force-pushed the WCM-316_add-teaser-attributes-to-volume branch from 55fde5e to 3b3017f Compare September 16, 2024 12:11
@Sinnaj94 Sinnaj94 force-pushed the WCM-316_add-teaser-attributes-to-volume branch from 3b3017f to c8072d2 Compare September 16, 2024 13:07
@Sinnaj94 Sinnaj94 marked this pull request as ready for review September 16, 2024 13:59
stollero
stollero approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@stollero stollero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht soweit voll in Ordnung aus, bis auf das Layout und mein fehlender Colorpicker. Oh je das ist echt eine Sache für sich. Aber das verfolgen wir erst einmal nicht weiter. Wenn wir mal wieder am Volume sind 👍

@stollero stollero merged commit af66db7 into main Sep 17, 2024
4 checks passed
@stollero stollero deleted the WCM-316_add-teaser-attributes-to-volume branch September 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greengiraffe greengiraffe greengiraffe left review comments

@wosc wosc wosc requested changes

@stollero stollero stollero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sinnaj94 @wosc @greengiraffe @stollero