Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZO-4683: Check date_last_modified instead of checksum #619

Merged
merged 4 commits into from
Feb 19, 2024
Merged

ZO-4683: Check date_last_modified instead of checksum #619

merged 4 commits into from
Feb 19, 2024

Conversation

louika
Copy link
Contributor

@louika louika commented Feb 14, 2024 •
edited
Loading

Checklist

gif

cleaning

@louika louika force-pushed the ZO-4683_article_tts_reference branch from 1698d30 to 7fedf0d Compare February 14, 2024 10:52
@louika louika marked this pull request as ready for review February 14, 2024 11:59
@louika louika requested a review from wosc February 14, 2024 11:59
@louika louika force-pushed the ZO-4683_article_tts_reference branch 2 times, most recently from d99ced9 to 0dc6693 Compare February 16, 2024 16:05
stollero
stollero requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@stollero stollero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im Ticket fehlt mir noch das Warum für diesen Lösungsansatz. Sonst 👍

core/src/zeit/speech/connection.py Outdated Show resolved Hide resolved
core/src/zeit/speech/connection.py Show resolved Hide resolved
core/src/zeit/speech/connection.py Outdated Show resolved Hide resolved
core/src/zeit/speech/connection.py Show resolved Hide resolved
@wosc wosc force-pushed the ZO-4683_article_tts_reference branch from 17e1f2f to 0d3f915 Compare February 19, 2024 08:58
@louika louika force-pushed the ZO-4683_article_tts_reference branch from 0d3f915 to 54d6d8e Compare February 19, 2024 09:59
@louika louika force-pushed the ZO-4683_article_tts_reference branch from 54d6d8e to c23b3d2 Compare February 19, 2024 12:38
stollero
stollero approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@stollero stollero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stollero stollero merged commit 47ae963 into main Feb 19, 2024
4 checks passed
@stollero stollero deleted the ZO-4683_article_tts_reference branch February 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wosc wosc wosc requested changes

@stollero stollero stollero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louika @wosc @stollero