ZO-4649: calculate checksum of article body and compare against tts audio before adding audio reference #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udio before adding audio reference
… a checksum calculate somalia article has no division element and this element is required to calculate a realistic checksum, after checkin the somalia article gets the element therefore we have another checksum after that even though we not changed the article
wosc
requested changes
Feb 8, 2024
core/src/zeit/speech/connection.py
Outdated
| @@ -110,7 +111,7 @@ def _article(self, speech: IAudio) -> IArticle: | |||
|
|
|||
| def _assert_checksum_matches(self, speech: IAudio) -> IArticle: | |||
| article = self._article(speech) | |||
| article_checksum = zeit.content.article.interfaces.ISpeechbertChecksum(article) | |||
| article_checksum = calculate_checksum(article, None) | |||
There was a problem hiding this comment.
Man könnte das ausrechnen auf den SpeechbertChecksum Adapter schieben (anstatt freischwebende Funktion), dann wär der Zusammenhang etwas klarer?
core/src/zeit/speech/connection.py
Outdated
| @@ -110,7 +111,7 @@ def _article(self, speech: IAudio) -> IArticle: | |||
|
|
|||
| def _assert_checksum_matches(self, speech: IAudio) -> IArticle: | |||
| article = self._article(speech) | |||
| article_checksum = zeit.content.article.interfaces.ISpeechbertChecksum(article) | |||
| article_checksum = calculate_checksum(article, None) | |||
There was a problem hiding this comment.
Und ich glaube, wir sollten die frisch berechnete Checksumme hier nicht speichern, oder? Denn sonst ist doch nicht mehr klar, auf welchen Stand sie sich bezieht (denn die sonstige Annahme ist ja, "wird before publish ausgerechnet").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
gif