[feat-684] fixed some map key element issues

Zagrios · Jan 1, 2025 · 1588c0d · 1588c0d
1 parent 284e379
commit 1588c0d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/renderer/components/modal/modal-types/mods/mods-version-compare-modal.component.tsx b/src/renderer/components/modal/modal-types/mods/mods-version-compare-modal.component.tsx
@@ -300,11 +300,9 @@ function ModCategory({
                 break;
             }
 
-            otherAvailableMods.forEach(mod => {
-                if (combinedMods.findIndex(cm => cm.name === mod.name) === -1) {
-                    combinedMods.push(mod);
-                }
-            });
+            combinedMods.push(...otherAvailableMods.filter(
+                mod => combinedMods.findIndex(cm => cm.name === mod.name) === -1
+            ));
             combinedMods.sort((m1, m2) => m1.name.localeCompare(m2.name));
             break;
 
@@ -335,7 +333,7 @@ function ModCategory({
         }}>
             {combinedMods.map(mod =>
                 <ModCompare
-                    key={mod._id}
+                    key={mod.name}
                     mod={availableMods.find(am => am.name === mod.name)}
                     installed={installedMods.findIndex(im => im.name === mod.name) > -1}
                     otherMod={otherAvailableMods.find(oam => oam.name === mod.name)}

diff --git a/src/renderer/components/version-viewer/slides/launch/launch-slide.component.tsx b/src/renderer/components/version-viewer/slides/launch/launch-slide.component.tsx
@@ -183,6 +183,7 @@ export function LaunchSlide({ version }: Props) {
                     if(launchMod?.visible === false || !launchMod?.pinned) { return undefined; }
                     return (
                         <LaunchModToogle
+                            key={launchMod.id}
                             icon={launchMod.icon}
                             infoText={launchMod.description}
                             text={launchMod.label}