Add possibility to disable auto-application of Moshi dependency #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Sep 6, 2024
| * Set this property to false to disable auto-application of the Moshi dependency. Enabled by | ||
| * default. | ||
| */ | ||
| val applyMoshi: Property<Boolean> = objects.property(Boolean::class.java).convention(true) |
There was a problem hiding this comment.
Let's call it applyMoshiDependency
There was a problem hiding this comment.
Ok, done (by amending previous commit)
plnice
force-pushed
the
plnice/option-to-disable-applying-moshi
branch
from
6bd53fd
to
1c669a6
Compare
plnice
force-pushed
the
plnice/option-to-disable-applying-moshi
branch
from
1c669a6
to
729541a
Compare
|
@ZacSweers which version will this flag be released in ? |
|
When it's released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to rely on manually applied, possibly newer version of Moshi dependency, and not auto-adding older version unnecessarily by the IR plugin.