Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all usages of findProperty #652

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

ansman
Copy link
Contributor

@ansman ansman commented Aug 18, 2024

It is not compatible with project isolation, providers.gradleProperty is however.

This PR also change all build script related usages, though this isn't needed for consumers of course.

It is not compatible with project isolation, `providers.gradleProperty`
is however.

This PR also change all build script related usages, though this isn't
needed for consumers of course.
Copy link
Owner

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZacSweers
Copy link
Owner

@ansman looks like CI is failing

@ansman
Copy link
Contributor Author

ansman commented Aug 23, 2024

Fill fix tomorrow, not in front of a computer today

build.gradle.kts Outdated
@@ -77,7 +77,8 @@ subprojects {
pluginManager.withPlugin("java") {
// javaReleaseVersion can be set to override the global version
val jvmTargetProvider =
provider<String> { findProperty("moshix.javaReleaseVersion") as? String? }
providers
.gradleProperty("moshix.javaReleaseVersion")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is here unfortunately, providers.gradleProperty() doesn't work for subprojects, only root projects

@ZacSweers ZacSweers merged commit 45d1705 into ZacSweers:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants