-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all usages of findProperty #652
Conversation
It is not compatible with project isolation, `providers.gradleProperty` is however. This PR also change all build script related usages, though this isn't needed for consumers of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ansman looks like CI is failing |
Fill fix tomorrow, not in front of a computer today |
build.gradle.kts
Outdated
@@ -77,7 +77,8 @@ subprojects { | |||
pluginManager.withPlugin("java") { | |||
// javaReleaseVersion can be set to override the global version | |||
val jvmTargetProvider = | |||
provider<String> { findProperty("moshix.javaReleaseVersion") as? String? } | |||
providers | |||
.gradleProperty("moshix.javaReleaseVersion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is here unfortunately, providers.gradleProperty()
doesn't work for subprojects, only root projects
It is not compatible with project isolation,
providers.gradleProperty
is however.This PR also change all build script related usages, though this isn't needed for consumers of course.