version bump, detect stdlib import #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
commented
Mar 13, 2024
| @@ -75,6 +75,8 @@ | |||
| # https://github.com/astral-sh/ruff/issues/10245 | |||
| # ruff replaces `sorted(reversed(iterable))` with `sorted(iterable)` | |||
| # "C414", # unnecessary-double-cast # codemod: `replace_unnecessary_nested_calls` | |||
|
|
|||
|
|
|||
| # ** These are new fixes that Zac had enabled in his branch | |||
There was a problem hiding this comment.
I initially only enabled checks that had a direct analog in autoflake/pyupgrade/isort/codemods, but that left a bunch that you had enabled in your branch. Presumably you added them because you thought they were useful to have enabled by default?
There was a problem hiding this comment.
@Zac-HD ... soooo should I do a separate PR where I do enable them?
There was a problem hiding this comment.
Open an issue and I'll get to in eventually?
The more important one to me personally is that our just-released shed no longer detects hypothesis' own test suite as first-party, and so all the imports get moved.
None of this is work-related though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick followup PR for #105