Support unauthenticated mail submission #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrmann
requested changes
Jul 29, 2019
| @@ -116,9 +116,6 @@ def make_mail(sender, recipient, subject, body, attachments): | |||
| if input("Abort? [y/N] ").lower() == "y": | |||
| sys.exit(0) | |||
|
|
|||
| username = args.username or input("Username: ") | |||
There was a problem hiding this comment.
Please keep this around and add a comment "(leave blank for unauthenticated login)"
| @@ -116,9 +116,6 @@ def make_mail(sender, recipient, subject, body, attachments): | |||
| if input("Abort? [y/N] ").lower() == "y": | |||
| sys.exit(0) | |||
|
|
|||
| username = args.username or input("Username: ") | |||
| password = getpass("Password: ") | |||
There was a problem hiding this comment.
Ask for the password here, if the username is truthy.
| @@ -129,7 +126,9 @@ def make_mail(sender, recipient, subject, body, attachments): | |||
| s.set_debuglevel(args.debug) | |||
| s.starttls(context=context) | |||
| s.ehlo() | |||
| s.login(user=username, password=password) | |||
| if args.username: | |||
| password = getpass("Password: ") | |||
There was a problem hiding this comment.
Asking for the password here is than not needed anymore.
| @@ -129,7 +126,9 @@ def make_mail(sender, recipient, subject, body, attachments): | |||
| s.set_debuglevel(args.debug) | |||
| s.starttls(context=context) | |||
| s.ehlo() | |||
| s.login(user=username, password=password) | |||
| if args.username: | |||
There was a problem hiding this comment.
This would be just if username then.
| s.login(user=username, password=password) | ||
| if args.username: | ||
| password = getpass("Password: ") | ||
| s.login(user=args.username, password=password) |
There was a problem hiding this comment.
Dito args.username to just username then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(bitte beim Mergen squashen...)