Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls support: dubbo/dubbo3/grpc protocol #19

Open
wants to merge 9 commits into
base: 3.0
Choose a base branch
from
Open

Conversation

ZLBer
Copy link
Owner

@ZLBer ZLBer commented Oct 7, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #19 (7bbf3d3) into 3.0 (9e4452a) will decrease coverage by 0.75%.
The diff coverage is 12.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0      #19      +/-   ##
==========================================
- Coverage   45.19%   44.44%   -0.76%     
==========================================
  Files         283      283              
  Lines       17572    17037     -535     
==========================================
- Hits         7942     7572     -370     
+ Misses       8797     8668     -129     
+ Partials      833      797      -36     
Impacted Files Coverage Δ
config/protocol_config.go 50.00% <ø> (-2.95%) ⬇️
config/reference_config.go 26.35% <ø> (-3.20%) ⬇️
config/root_config.go 69.79% <ø> (+0.92%) ⬆️
config/service_config.go 53.04% <ø> (-5.21%) ⬇️
config/ssl_config.go 100.00% <ø> (ø)
config/tls_config.go 0.00% <ø> (ø)
remoting/getty/config.go 66.32% <ø> (-2.57%) ⬇️
remoting/getty/getty_server.go 46.49% <0.00%> (-9.28%) ⬇️
remoting/getty/getty_client.go 43.60% <12.50%> (-7.22%) ⬇️
protocol/dubbo3/dubbo3_invoker.go 53.27% <14.28%> (-9.64%) ⬇️
... and 20 more

@ZLBer ZLBer force-pushed the add_tls_support branch 2 times, most recently from 9c2a1c9 to ebbe9c3 Compare October 22, 2022 03:27
@ZLBer ZLBer force-pushed the add_tls_support branch 3 times, most recently from bd1570b to 34416ff Compare November 20, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant