UTF8 for the win + lot of housekeeping #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phobos is no longer the target, but I might think about it. |
What is the target now? |
I'm collecting some input on it from others. |
|
After some thinking, I came to this conclusion:
Even if I decide to later put it out as a Phobos candidate, it'll be easy to undo it, currently it might be more beneficial to keep some configurability of the library. Sometimes it's more practical to use UTF16 or something else (certain East Asian texts benefit from that), which is standard for XML DOM. |
|
Okay, it's time to swallow the poison pill for my projects. Accepting it, but likely will keep the 0.2.1 version around for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO if this is to end up in phobos UTF8 is the way to, this also means no DOMstring.
The rest is mostly boring housekeeping and formatting.