Added FloatBobFactor to actor properties #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new actor property: `FloatBobFactor` (default 1.0). This will be a multiplier for level.time in `AActor::GetBobOffset`, which finally allows to control not only the range of float bobbing (which is FloatBobStrength) but also the frequency of bobbing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new actor property:
FloatBobFactor(default 1.0). This will function as a multiplier for level.time inAActor::GetBobOffset, which will finally allow to control not only the range of float bobbing (which is determined byFloatBobStrength) but also the frequency of bobbing.Note, I also added an error that will appear if the value is 0 or lower. I can remove it, since technically it shouldn't break anything, but using 0 or negative seems pointless (unless I'm missing something), so it seemed warranted to me.
P.S. Initially considered calling it "FloatBobSpeed", but due to how it's used, it's clearly a factor, so FloatBobFactor seems more fitting.