-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fire textures in ANIMDEFS #2680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this work in the software renderer as well.
e06c182
to
f552441
Compare
Is implementing |
Why don't you just test it? |
It only works with the hardware renderer and the non-truecolor software renderer. On truecolor software renderer it remains frozen. |
My suggestion here would be to look how warped flats force their update and replicate it for this texture. |
f552441
to
55618fc
Compare
Fixed for truecolor software renderer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardware and paletted software renderer are working - but for the true color software renderer the black background is transparent and causes HOM.
Does this texture need the transparency for black? If not, make it fully opaque.
It needs the black parts to be fully transparent otherwise it will be rendered useless for dual sky parallax effects. |
As an addendum: Specifying the first color with the |
It may be a bug in the true color software renderer, but I don't really know how to address it. |
Does this happen with the sky or just linedefs? At least I could attempt fixing the truecolor sky renderer but I'm not sure about anything else. |
It happens with the sky, not linedefs. I have no idea why it happens; the sky drawer code's not easy to read. |
Defining an opaque black color as the first one indeed deals with the HOM problem. |
Fixes HOM effect
The HOM problem should be addressed now. |
Seems to work now |
This PR adds support for defining fire textures in ANIMDEFS.
Syntax is:
FIRETEXTURE tics
followed by a series of either "palette index" or "color red green blue alpha".
Example (converted from Legacy of Rust's SKYDEFS definition):