Fix building ZVulkan on *BSD #2253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the hardcoded libdl. *BSD's don't have/use libdl. CMAKE_DL_LIBS is set to libdl as well on the appropraite other OS's.
|
SOME platforms needed this, otherwise it would not have been added like this. |
|
Yeah I am not going to accept this change as-is. If this has the potential to break any of our officially supported platforms I will not break them for the sake of one that is very distantly supported. |
|
In defense of brad0, If there's any bug it should be directed to CMake developers, instead of adding hacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hardcoded libdl. *BSD's don't have/use libdl. CMAKE_DL_LIBS is set to libdl as well on the appropraite other OS's.