Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cvar to control camera bob factor #1946

Closed
wants to merge 1 commit into from

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Jan 15, 2023

This allows disabling camera bobbing without disabling weapon sprite bobbing. The landing camera effect is not affected by this cvar.

This is a multiplier, which means 1.0 is the original behavior and 0.0 fully disables camera bobbing (including stillbob, but not fly bobbing, which is controlled by the fviewbob boolean cvar).

This partially addresses #1934.

Preview

Using the following settings:

camerabob 0.0  // disables camera bobbing
movebob 0.015  // strongly decreased to better mesh with the doubled weapon bob speed from this example
stillbob 0.0   // default
wbobspeed 2.0  // doubled from default
wbobfire 1.0   // keeps full weapon bobbing while firing
out.mp4

This allows disabling camera bobbing without disabling weapon sprite
bobbing. The landing camera effect is not affected by this cvar.

This is a multiplier, which means 1.0 is the original behavior and
0.0 fully disables camera bobbing (including `stillbob`, but not
fly bobbing, which is controlled by the `fviewbob` boolean cvar).
@RicardoLuis0
Copy link
Collaborator

RicardoLuis0 commented Jan 15, 2023

this doesn't feel like the right approach to me, IMO instead of adding a multiplier for view bob, the better option would be to decouple the movebob/stillbob CVARs from weapon bob entirely, with a separate weaponbob CVAR for weapon bobbing

@MajorCooke
Copy link
Contributor

I'll hold off merging this into QZDoom until a dev can review the code first.

@CandiceJoy
Copy link
Member

this doesn't feel like the right approach to me, IMO instead of adding a multiplier for view bob, the better option would be to decouple the movebob/stillbob CVARs from weapon bob entirely, with a separate weaponbob CVAR for weapon bobbing

I tend to agree with this. It feels more like a bandaid than a true fix. But that’s just my 2 cents ^_^

@RicardoLuis0
Copy link
Collaborator

reiterating:

instead of adding a multiplier for view bob, the better option would be to decouple the movebob/stillbob CVARs from weapon bob entirely, with a separate weaponbob CVAR for weapon bobbing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants