Skip to content

Commit

Permalink
- fix Strife-style startup asset check.
Browse files Browse the repository at this point in the history
The STARTUP0 check is not only redundant but also was wrong. It already gets checked and validated in the asset loading loop, and this up-front check did not handle placement as a graphic.
  • Loading branch information
prof-hastig authored and coelckers committed Sep 15, 2023
1 parent eb93c76 commit 85ba35a
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions src/common/startscreen/startscreen_strife.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,10 @@ class FStrifeStartScreen : public FStartScreen
FStrifeStartScreen::FStrifeStartScreen(int max_progress)
: FStartScreen(max_progress)
{
// at this point we do not have a working texture manager yet, so we have to do the lookup via the file system

int startup_lump = fileSystem.CheckNumForName("STARTUP0");

if (startup_lump < 0)
{
I_Error("bad startscreen assets");
}

StartupBitmap.Create(320, 200);

// Load the animated overlays.
// at this point we do not have a working texture manager yet, so we have to do the lookup via the file system
// Load the background and animated overlays.
for (size_t i = 0; i < countof(StrifeStartupPicNames); ++i)
{
int lumpnum = fileSystem.CheckNumForName(StrifeStartupPicNames[i], FileSys::ns_graphics);
Expand Down

0 comments on commit 85ba35a

Please sign in to comment.