Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release branch 7.1.0 #1697

Merged
merged 91 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
ec87865
add widget
AdamVe Jun 8, 2023
3a0972e
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Sep 26, 2023
44844c7
add widgets for different nfc states
AdamVe Sep 26, 2023
39dfa17
add and use fade_in_out widget
AdamVe Sep 26, 2023
325a0be
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Sep 27, 2023
16e3d32
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Nov 15, 2023
9a7a1e7
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Jul 31, 2024
4ec2698
fix formatting
AdamVe Jul 31, 2024
69ff029
revert naming
AdamVe Jul 31, 2024
a82bcce
Merge branch main into adamve/nfc_activity_widget
AdamVe Aug 25, 2024
b0599ec
Merge branch main into adamve/nfc_activity_widget
AdamVe Aug 26, 2024
32d9cb1
Merge branch main into adamve/nfc_activity_widget
AdamVe Aug 28, 2024
d8a55a0
first version of the feature, wip still
AdamVe Aug 28, 2024
0cf46fd
shorten localization key names
AdamVe Aug 28, 2024
3ef1276
fix strings errors
AdamVe Aug 29, 2024
8b2126d
unfocus correctly to hide sw keyboard
AdamVe Aug 29, 2024
7924a3c
review and improve unfocus changes
AdamVe Aug 29, 2024
7c9beca
Merge 'main' into adamve/nfc_activity_widget
AdamVe Aug 30, 2024
a21691c
update class names, cleanup
AdamVe Aug 30, 2024
075ce16
replace pulsing widget with nfc progressbar
AdamVe Aug 30, 2024
4534120
remove unused widgets
AdamVe Aug 30, 2024
cc761c3
update naming style
AdamVe Aug 30, 2024
44e3bc7
refactor
AdamVe Aug 30, 2024
dd1c52f
add helper methods for commands
AdamVe Aug 30, 2024
f99b0b1
update dialog titles
AdamVe Aug 30, 2024
f500932
provide icon widget to nfc content vidget
AdamVe Aug 30, 2024
c3b0c79
unify dialog title, add success icon
AdamVe Aug 30, 2024
afaab49
add close button to the bottom sheet
AdamVe Aug 30, 2024
34f78d2
support for FIDO, conditional messages
AdamVe Aug 31, 2024
9cbe8c0
Merge branch main into adamve/nfc_activity_widget
AdamVe Sep 3, 2024
f98e34b
support retries on NFC failure
AdamVe Sep 4, 2024
3873ec4
Merge branch main into adamve/nfc_activity_widget
AdamVe Sep 4, 2024
fb2bec0
schedule device info update in fido and oath
AdamVe Sep 5, 2024
516d776
fix pop stack on device change, support nfc retry
AdamVe Sep 5, 2024
4e1abf2
handle app context changes
AdamVe Sep 5, 2024
d677dfe
improve exception handling
AdamVe Sep 5, 2024
2de217d
refactor autoclose views
AdamVe Sep 5, 2024
9f183bc
minor nfc views refactor
AdamVe Sep 6, 2024
673f5e1
remove unused c_ prefix
AdamVe Sep 6, 2024
abde264
UX updates
AdamVe Sep 6, 2024
63a1d8d
cleanup localizations
AdamVe Sep 6, 2024
b2a183e
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Sep 6, 2024
f989d38
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Sep 6, 2024
454d364
Use correct l10n key
AdamVe Sep 6, 2024
75073c1
refactor
AdamVe Sep 6, 2024
f14f16e
refactor
AdamVe Sep 6, 2024
ec42889
remove explicitAction variable
AdamVe Sep 9, 2024
937893a
update flutter file structure
AdamVe Sep 9, 2024
fea3d4b
cleanup
AdamVe Sep 9, 2024
58552c0
simplify method channel calls
AdamVe Sep 9, 2024
17e3837
shorten names, refactor
AdamVe Sep 9, 2024
dc8822d
update class name
AdamVe Sep 9, 2024
e5e6164
update names for overlay in native code
AdamVe Sep 9, 2024
7b971f1
remove nfc retries
AdamVe Sep 10, 2024
5441c95
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Sep 10, 2024
58167e6
minor fixes
AdamVe Sep 10, 2024
a6038ca
emit nfc overlay messages after FIDO reset
AdamVe Sep 10, 2024
1ce9797
Bump version to 7.1.0
dainnilsson Sep 10, 2024
4e25fca
Update l10n from Crowdin
dainnilsson Sep 10, 2024
827c95f
handle IO exceptions correctly
AdamVe Sep 10, 2024
90cd67a
preserve connections in addToAny methods
AdamVe Sep 10, 2024
3432835
use correct context/section for AddToAny
AdamVe Sep 10, 2024
769aeda
improve comparison to handle exception states
AdamVe Sep 11, 2024
a79e2da
don't swallow context disposed exceptions
AdamVe Sep 11, 2024
96d366e
Merge branch 'main' into adamve/nfc_activity_widget
AdamVe Sep 11, 2024
835749d
Merge branch 'adamve/nfc_activity_widget'
AdamVe Sep 11, 2024
2d394d8
fix copyright year in changed files
AdamVe Sep 11, 2024
56702f9
Fix minor helper issues
dainnilsson Sep 11, 2024
accbb3a
Only refresh OATH while page is active
dainnilsson Sep 11, 2024
7fa2786
Merge PR #1686
AdamVe Sep 11, 2024
9834672
Helper: Don't return closed child
dainnilsson Sep 11, 2024
bb00b2c
CTAP: Handle expired PIN token
dainnilsson Sep 11, 2024
f38e5a5
Default to home when section is not enabled
elibon99 Sep 11, 2024
ba7dac7
Remove broken caching, refresh OATH state on capability change
dainnilsson Sep 12, 2024
ea0a7d2
catch exceptions during initial NFC connections
AdamVe Sep 12, 2024
ce95119
review fixes
AdamVe Sep 12, 2024
3f8e69a
refactor exception handling in rename dialog
AdamVe Sep 13, 2024
5a24f57
Merge PR #1688
AdamVe Sep 13, 2024
815150d
don't show progress widgets when using NFC
AdamVe Sep 13, 2024
d8e9cf3
Refactor DeviceInfo caching
dainnilsson Sep 13, 2024
5ba0957
Helper: More DeviceInfo improvements
dainnilsson Sep 13, 2024
3099cfc
Helper: Improve connection switching when toggling interfaces
dainnilsson Sep 13, 2024
5637d90
fix code style
AdamVe Sep 13, 2024
8d9e9e2
Simplify condition
AdamVe Sep 13, 2024
aa485d4
Merge PR #1689
AdamVe Sep 13, 2024
e12c9a4
Only use NFC if available
AdamVe Sep 13, 2024
1d69a3c
Merge PR #1690
AdamVe Sep 13, 2024
b68798d
Improve AddToAny when NFC not available
AdamVe Sep 16, 2024
2e94f0a
Merge PR #1692
AdamVe Sep 17, 2024
1a9db69
Update NEWS
dainnilsson Sep 25, 2024
acfd00b
Bump version
dainnilsson Sep 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
* Version 7.1.0 (released 2024-09-25)
** Improved support for YubiKey Bio - Multi-protocol Edition.
** Improved support for YubiKey 5.7 FIPS:
*** Use secure messaging (SCP11b) when needed over NFC.
*** Add FIPS status information to Home screen and application pages.
*** Disable locked features in UI while not in FIPS approved mode.
** Android: Improve UI for NFC communication.
** Android: Improve error messages shown in UI.
** FIDO: Add button to enable Enterprise Attestation on supported devices.
** UI: Add instructions for enabling NFC for NFC-restricted devices.
** UI: Display PIN complexity info on Home screen for applicable devices.
** UI: Add grid views for OATH and Passkey credential lists.
** UI: Add toggling of visibility to the right sidebar menu.

* Version 7.0.1 (released 2024-05-30) Android only release
** Fix: Opening the app by NFC tap needs another tap to reveal accounts.
** Fix: NFC devices attached to mobile phone prevent usage of USB YubiKeys.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@ import com.yubico.yubikit.core.YubiKeyDevice
* Provides behavior to run when a YubiKey is inserted/tapped for a specific view of the app.
*/
abstract class AppContextManager {
abstract suspend fun processYubiKey(device: YubiKeyDevice)
abstract suspend fun processYubiKey(device: YubiKeyDevice): Boolean

open fun dispose() {}

open fun onPause() {}
}

open fun onError(e: Exception) {}
}

class ContextDisposedException : Exception()
105 changes: 0 additions & 105 deletions android/app/src/main/kotlin/com/yubico/authenticator/DialogManager.kt

This file was deleted.

Loading
Loading