Implement initiative ranking command #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rank field is meant as a generic stand-in for the table top concept of initiative. This includes two values so that the rank can be temporarily modified by status effects or death and be restored to its original value when these effects pass.
Requires some unique rules defined here: https://peps.python.org/pep-0484/#forward-references
Implements a basic ranking system for NPCs in which a higher value places them higher in their listing. This command might require displaying output once it finishes since it could be hard to visualize how it would affect the current list.
This change is made in preparation for sorting the encounter list after every command. This could be potentially wasteful, but would also ensure NPC ranking is always up to date. This new change excludes empty inputs from processing allowing for some trimmed down code branching. This code also provides a soft error message in the case the user provides some input that is visually empty, i.e. all whitespace or entirely empty, by changing the command prompt back to its longer form.
Should allow github's test runners to run properly again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits create an initial implementation of the initiative/ranking command.
Simplifying the program's main loop was done to make it easier to sort NPCs by rank in the future.