Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Restructure packages #561

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
48c3d32
Updated package.json so Jest excludes dist and node_modules directories
Mar 16, 2020
8033563
Ensured eslint package has a proper file structure
Mar 16, 2020
5ad3832
Moved setupTests to tools directory.
Mar 16, 2020
59f4c2a
Moved components setupTests file to tools directory
Mar 16, 2020
f71104f
Updated folder structure for the yoast-components package
Mar 16, 2020
3fe2c9d
Altered path names to grunt configuration locations for yoast-compone…
Mar 16, 2020
b2d1946
Updated the folder structure for yoast-social-previews
Mar 16, 2020
b206e6d
Updated the folder structure for yoastseo package
Mar 17, 2020
467183b
Reverted placing CSS in src dir for yoast-components dir
Mar 17, 2020
2f5c033
Reverted placing CSS in src dir for yoast-social-previews package
Mar 17, 2020
cd5714e
Added .idea folders to .gitignore
Mar 17, 2020
4416b56
Removed duplicate templates dir from yoast-social-previews
Mar 17, 2020
c926189
Removed duplicate css dir from yoast-social-previews and fixed faulty…
Mar 17, 2020
139bd1d
Updated package.json so Jest excludes dist and node_modules directories
Mar 16, 2020
ff7a864
Ensured eslint package has a proper file structure
Mar 16, 2020
c907f37
Moved setupTests to tools directory.
Mar 16, 2020
89f4989
Moved components setupTests file to tools directory
Mar 16, 2020
5ea8d0b
Updated folder structure for the yoast-components package
Mar 16, 2020
e80c9cc
Altered path names to grunt configuration locations for yoast-compone…
Mar 16, 2020
f545941
Updated the folder structure for yoast-social-previews
Mar 16, 2020
0f86b94
Updated the folder structure for yoastseo package
Mar 17, 2020
716d1ca
Reverted placing CSS in src dir for yoast-components dir
Mar 17, 2020
165c073
Reverted placing CSS in src dir for yoast-social-previews package
Mar 17, 2020
53db2a1
Added .idea folders to .gitignore
Mar 17, 2020
2d83753
Removed duplicate templates dir from yoast-social-previews
Mar 17, 2020
21e7ba2
Removed duplicate css dir from yoast-social-previews and fixed faulty…
Mar 17, 2020
7f7d4f6
Merge branch 'restructure-packages' of https://github.com/Yoast/javas…
Mar 17, 2020
dccbf8e
Fixed faulty path in Gruntfile
Mar 17, 2020
0cef625
Fixed faulty pathnames
Mar 17, 2020
12572d9
Removed old setupTests file from components package
Mar 17, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ yarn-error.log
coverage
dependencies.json
dependencies.md
/.idea/
2 changes: 1 addition & 1 deletion apps/components/ContentAnalysisWrapper.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react";

import ExamplesContainer from "./ExamplesContainer";
import ContentAnalysis from "yoast-components/composites/Plugin/ContentAnalysis/components/ContentAnalysis";
import ContentAnalysis from "yoast-components/src/composites/Plugin/ContentAnalysis/components/ContentAnalysis";
import LanguageNoticeWrapper from "./LanguageNoticeWrapper.js";

/**
Expand Down
2 changes: 1 addition & 1 deletion apps/components/FacebookPreviewExample.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react";

import ExamplesContainer from "./ExamplesContainer";
import FacebookPreview from "yoast-components/composites/Plugin/SocialPreviews/Facebook/components/FacebookPreview";
import FacebookPreview from "yoast-components/src/composites/Plugin/SocialPreviews/Facebook/components/FacebookPreview";

/**
* Returns the FacebookPreview examples.
Expand Down
2 changes: 1 addition & 1 deletion apps/components/reducers/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { combineReducers } from "redux";

import contentAnalysis from "yoast-components/composites/Plugin/ContentAnalysis/reducers/contentAnalysisReducer";
import contentAnalysis from "yoast-components/src/composites/Plugin/ContentAnalysis/reducers/contentAnalysisReducer";

export default combineReducers( {
contentAnalysis,
Expand Down
5 changes: 4 additions & 1 deletion packages/analysis-report/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@
"transformIgnorePatterns": [
"/node_modules/(?!yoastseo|lodash-es).+\\.js$"
],
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js"
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js",
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"publishConfig": {
"access": "public"
Expand Down
5 changes: 4 additions & 1 deletion packages/browserslist-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
},
"jest": {
"testRegex": ".*Test.js$",
"testEnvironment": "node"
"testEnvironment": "node",
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"devDependencies": {
"browserslist": "^4.7.3"
Expand Down
5 changes: 4 additions & 1 deletion packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@
"jest": {
"testRegex": ".*Test.js$",
"testURL": "http://localhost",
"setupTestFrameworkScriptFile": "<rootDir>/jest/setupTests.js"
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js",
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"dependencies": {
"@wordpress/a11y": "^1.1.3",
Expand Down
3 changes: 3 additions & 0 deletions packages/configuration-wizard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@
},
"transformIgnorePatterns": [
"/node_modules/(?!yoastseo|lodash-es).+\\.js$"
],
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"eslint",
"eslintconfig"
],
"main": "index.js",
"main": "src/index.js",
"repository": {
"type": "git",
"url": "https://github.com/Yoast/javascript.git",
Expand Down
File renamed without changes.
5 changes: 4 additions & 1 deletion packages/feature-flag/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
"transformIgnorePatterns": [
"/node_modules/(?!yoastseo|lodash-es).+\\.js$"
],
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js"
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js",
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"publishConfig": {
"access": "public"
Expand Down
5 changes: 4 additions & 1 deletion packages/helpers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
"jest": {
"testRegex": ".*Test.js$",
"testEnvironment": "node",
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js"
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js",
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"devDependencies": {
"@yoast/browserslist-config": "^1.2.1",
Expand Down
5 changes: 4 additions & 1 deletion packages/search-metadata-previews/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@
"transformIgnorePatterns": [
"/node_modules/(?!yoastseo|lodash-es).+\\.js$"
],
"setupTestFrameworkScriptFile": "<rootDir>/tests/setupTests.js"
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js",
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"publishConfig": {
"access": "public"
Expand Down
6 changes: 3 additions & 3 deletions packages/yoast-components/Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ module.exports = function( grunt ) {
// Define project configuration
const project = {
paths: {
grunt: "grunt/",
grunt: "tools/grunt/",
get config() {
return this.grunt + "config/";
},
},
files: {
components: [
"**/*.js",
"*.js",
"src/**/*.js",
"src/*.js",
"!node_modules/**",
"!node_modules/*",
],
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion packages/yoast-components/css/standalone.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Requires Sass Dash
@import "../node_modules/sassdash/scss/sassdash";
@import "./all";
@import "all";

body {
background: #f1f1f1;
Expand Down
19 changes: 11 additions & 8 deletions packages/yoast-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"url": "https://github.com/Yoast/javascript.git",
"directory": "packages/yoast-components"
},
"main": "index.js",
"main": "src/index.js",
"scripts": {
"start": "echo 'The yoast-components demo app has been moved to javascript/apps/components (https://github.com/Yoast/javascript/tree/develop/apps/components). Please run yarn start there.'",
"test": "jest",
Expand All @@ -18,8 +18,8 @@
"jest": {
"testURL": "http://localhost",
"moduleNameMapper": {
"\\.(jpg|jpeg|png|gif|eot|otf|webp|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/jest/__mocks__/fileMock.js",
"\\.(css|less)$": "<rootDir>/jest/__mocks__/styleMock.js"
"\\.(jpg|jpeg|png|gif|eot|otf|webp|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/tests/__mocks__/fileMock.js",
"\\.(css|less)$": "<rootDir>/tests/__mocks__/styleMock.js"
},
"unmockedModulePathPatterns": [
"react",
Expand All @@ -33,15 +33,15 @@
],
"testRegex": ".*Test.js$",
"coverageDirectory": "coverage",
"setupTestFrameworkScriptFile": "<rootDir>/jest/setupTests.js",
"setupTestFrameworkScriptFile": "<rootDir>/tools/jest/setupTests.js",
"collectCoverageFrom": [
"**/*.js",
"src/**/*.js",
"!**/*.*Test.js",
"!grunt/**/*.js",
"!tools/grunt/**/*.js",
"!*.js",
"!app/**/*.js",
"!a11y/examples/example.js",
"!utils/helpers/*.js",
"!src/a11y/examples/example.js",
"!src/utils/helpers/*.js",
"!coverage/**/*.js"
],
"snapshotSerializers": [
Expand All @@ -52,6 +52,9 @@
},
"transformIgnorePatterns": [
"/node_modules/(?!yoastseo|lodash-es).+\\.js$"
],
"modulePathIgnorePatterns": [
"<rootDir>[/\\\\](dist|node_modules)[/\\\\]"
]
},
"author": "Yoast",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { readabilityResultsReducer } from "./contentAnalysis/readabilityResultsReducer";
import { keywordResultsReducer } from "./contentAnalysis/keywordResultsReducer";
import { combineReducers } from "redux";

export default combineReducers( {
seo: keywordResultsReducer,
readability: readabilityResultsReducer,
} );
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { UPDATE_SEO_RESULT } from "../../actions/contentAnalysis";
import contentAnalysisReducer from "../../reducers/contentAnalysisReducer";
import contentAnalysisReducer from "../contentAnalysisReducer";

jest.mock( "../../reducers/contentAnalysis/readabilityResultsReducer", () => {
return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = {
files: [ {
src: [
".babelrc",
"**/*",
"src/**/*",
"!dist/**/*",
"!node_modules/**/*",
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ module.exports = {
],
},
build: {
src: "css-dist/yoast-components.min.css",
src: "dist/css/yoast-components.min.css",
},
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ module.exports = {
},
build: {
files: {
"css-dist/yoast-components.min.css": "css/all.scss",
"css-dist/yoast-components-standalone.min.css": "css/standalone.scss",
"dist/css/yoast-components.min.css": "css/all.scss",
"dist/css/yoast-components-standalone.min.css": "css/standalone.scss",
},
},
example: {
Expand Down
1 change: 1 addition & 0 deletions packages/yoast-social-previews/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/node_modules/
/.idea/
/dist/
2 changes: 1 addition & 1 deletion packages/yoast-social-previews/.istanbul.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
instrumentation:
root: js
root: src/js
extensions:
- .js
include-all-sources: true
12 changes: 6 additions & 6 deletions packages/yoast-social-previews/Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@ module.exports = function( grunt ) {
// Define project configuration.
var project = {
paths: {
grunt: "grunt/",
js: "js/",
grunt: "tools/grunt/",
js: "src/js/",
css: "css/",
get config() {
return this.grunt + "config/";
},
},
files: {
js: [
"js/**/*.js",
"grunt/config/*.js",
"!js/config/*.js",
"src/js/**/*.js",
"tools/grunt/config/*.js",
"!src/js/config/*.js",
"<%= files.grunt %>",
],
jsDontLint: [
"!js/templates.js",
"!src/js/templates.js",
],
scss: "css/*.scss",
templates: "templates/**/*.jst",
Expand Down
4 changes: 2 additions & 2 deletions packages/yoast-social-previews/example/example.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var FacebookPreview = require( "../js/facebookPreview.js" );
var TwitterPreview = require( "../js/twitterPreview.js" );
var FacebookPreview = require( "../src/js/facebookPreview.js" );
var TwitterPreview = require( "../src/js/twitterPreview.js" );

var facebookPreview = new FacebookPreview(
{
Expand Down
3 changes: 0 additions & 3 deletions packages/yoast-social-previews/grunt/config/eslint.js

This file was deleted.

2 changes: 1 addition & 1 deletion packages/yoast-social-previews/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.8.1",
"description": "",
"private": true,
"main": "index.js",
"main": "src/index.js",
"scripts": {
"test": "istanbul test jasmine"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/yoast-social-previews/spec/fields/buttonSpec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var Button = require( "../../js/inputs/button" );
var Button = require( "../../src/js/inputs/button" );

describe( 'a button', function() {
it( 'should accept a value', function() {
Expand Down
2 changes: 1 addition & 1 deletion packages/yoast-social-previews/spec/fields/textAreaSpec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var TextArea = require( "../../js/inputs/textarea" );
var TextArea = require( "../../src/js/inputs/textarea" );

describe( 'a text area', function() {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var TextField = require( "../../js/inputs/textInput" );
var TextField = require( "../../src/js/inputs/textInput" );

describe( 'a text field', function() {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var addModifier = require( "../../../js/helpers/bem/addModifier" );
var addModifier = require( "../../../src/js/helpers/bem/addModifier" );

describe( "addModifier", function() {
var mockElement, mockParent;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var addModifierToClass = require( "../../../js/helpers/bem/addModifierToClass" );
var addModifierToClass = require( "../../../src/js/helpers/bem/addModifierToClass" );

describe( "addModifierToClass", function() {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var removeModifier = require( "../../../js/helpers/bem/removeModifier" );
var removeModifier = require( "../../../src/js/helpers/bem/removeModifier" );

describe( "removeModifier", function() {
var mockElement, mockParent;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var addClass = require( "./../addClass" );
var addClass = require( "../addClass" );
var addModifierToClass = require( "./addModifierToClass" );

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var removeClass = require( "./../removeClass" );
var removeClass = require( "../removeClass" );
var addModifierToClass = require( "./addModifierToClass" );

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var defaults = require( "lodash/object/defaults" );
var buttonTemplate = require( "../../js/templates" ).fields.button;
var buttonTemplate = require( "../templates" ).fields.button;
var minimizeHtml = require( "../helpers/minimizeHtml" );
var defaultAttributes = {
value: "",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
var undefined;

/** Used as the semantic version number. */
var VERSION = '4.17.4';
var VERSION = '4.17.5';

/** Used as references for various `Number` constants. */
var INFINITY = 1 / 0;
Expand Down
3 changes: 3 additions & 0 deletions packages/yoast-social-previews/tools/grunt/config/eslint.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
target: [ "<%= files.js %>", "!src/js/templates.js" ],
};
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// See https://github.com/lodash-archive/grunt-lodash
module.exports = {
templates: {
dest: "js/templates.js",
dest: "src/js/templates.js",
options: {
exports: [ "node" ],
template: "<%= files.templates %>",
Expand Down
Loading