Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputMethodEditor #188

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Add InputMethodEditor #188

merged 3 commits into from
Sep 1, 2024

Conversation

Mr-X-GTA
Copy link
Contributor

No description provided.

Copy link
Contributor

@gir489returns gir489returns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to include this into classes.cpp and then make sure it builds.

Copy link
Contributor

@gir489returns gir489returns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing on linux for reasons I do not care.

@Yimura
Copy link
Owner

Yimura commented Aug 29, 2024

The static_assertion works on MSVC but not on gcc? Weird...

@Mr-X-GTA
Copy link
Contributor Author

Because wchar_t is 4 bytes on Linux

@gir489returns
Copy link
Contributor

The static_assertion works on MSVC but not on gcc? Weird...

https://gcc.gnu.org/onlinedocs/gcc/Structure-Layout-Pragmas.html

Pragma pack is a Microsoft thing.

@gir489returns
Copy link
Contributor

Because wchar_t is 4 bytes on Linux

Could probably fix that with allignas(8)

@Yimura
Copy link
Owner

Yimura commented Aug 29, 2024

Is this really the first PR with wchar_t?

@Mr-X-GTA
Copy link
Contributor Author

Mr-X-GTA commented Aug 29, 2024

Should I change it to char16_t?

char16_t m_current_text[142]; //0x002C

@xiaoxiao921
Copy link
Contributor

GTA is a MSVC compiled game for Windows, why is there even a CI for linux?

@Yimura
Copy link
Owner

Yimura commented Aug 29, 2024

Ahaha, previously I used char16_t

char16_t m_current_text[142]; //0x002C

@gir489returns
Copy link
Contributor

GTA is a MSVC compiled game for Windows, why is there even a CI for linux?

Because linuxcucks complained that they can't compile it without using MSVC.

@Yimura
Copy link
Owner

Yimura commented Aug 29, 2024

GTA is a MSVC compiled game for Windows, why is there even a CI for linux?

External linux cheat support.

@xiaoxiao921
Copy link
Contributor

GTA is a MSVC compiled game for Windows, why is there even a CI for linux?

Because linuxcucks complained that they can't compile it without using MSVC.

YimMenu is fully compilable with this package https://aur.archlinux.org/packages/msvc-wine-git

I propose removing the linux CI.

@gir489returns
Copy link
Contributor

I propose removing the linux CI.

Agreed.

@Yimura Yimura merged commit b98cf8d into Yimura:master Sep 1, 2024
2 checks passed
@Mr-X-GTA Mr-X-GTA deleted the IME branch September 24, 2024 22:45
Mr-X-GTA added a commit to Mr-X-GTA/GTAV-Classes-1 that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants