Basic online compatibility and a lot of other stuff

[maybegreat48]

• Added an anticheat bypass
• Fixed noclip
• Added settings serialization
• Refactored the GUI
• Added some protections (does not currently block every crash)
• Notification Service
• Players list

TODO:

• Readd column components

[github-actions]

Download the artifacts for this pull request:

• binary.zip

[DayibBaba]

Were the hotkeys broken on the main branch?

[DayibBaba]

Is the migrationdatanode bs the same here as in gta?

[maybegreat48]

Is the migrationdatanode bs the same here as in gta?

Yes. The P2Cs apparently ported that from YimMenu

[DayibBaba]

Is the migrationdatanode bs the same here as in gta?

Yes. The P2Cs apparently ported that from YimMenu

Figures

[MarkEcza]

Please split the PR next time, title is "Basic online compatibility" but i see you refactored the GUI and did other stuff that has nothing to do with online. It would be better if you do them one pr at a time so we can also review them easily and rapidly. That way we can avoid unnecessary code bugs and issues.

[DayibBaba]

Does this really return an Entity?

[maybegreat48]

It doesn't, but we don't have a ped helper class yet

[MarkEcza]

It doesn't, but we don't have a ped helper class yet

PTR to handle? You already have it.

[MarkEcza]

Wait does this even compile with no warnings/errors?

[maybegreat48]

It actually does

[DayibBaba]

It actually does

We were just confused about Entity being a class instead of a typedef here. Odd name for that class.

[MarkEcza]

Is this really needed?

[maybegreat48]

I'd like to isolate core and reuse it for other projects like YimMenuV2

[MarkEcza]

I'd like to isolate core and reuse it for other projects like YimMenuV2

I mean the m_OptionsFont nullptr check

[maybegreat48]

You can choose not to have an options font

[MarkEcza]

Also is hotkeys fixed?

[MarkEcza]

"TODO:

Readd column components

"?

class next_column : public option {
    public:
		next_column() {};

		void draw() override {
			ImGui::NextColumn();
		}
	};

	class set_column_offset : public option {
	public:
		set_column_offset(int column, int offset) : m_column(column), m_offset(offset) {};

		void draw() override {
			ImGui::SetColumnOffset(m_column, m_offset);
		}
	private:
		int m_column;
		int m_offset;
	};

	class column : public option {
	public:
		column(int columns) : m_columns(columns) {};

		void add_option(std::shared_ptr<option> box) {
			m_options.push_back(std::move(box));
		}

		void add_next_column() {
			m_options.push_back(std::make_shared<next_column>());
		}

		void add_offset(int column, int offset) {
			m_options.push_back(std::make_shared<set_column_offset>(column, offset));
		
		}

		void draw() override {

			ImGui::Columns(m_columns);

			for (const auto& box : m_options) {
				if (box) {
					box->draw();
				}			
			}
		}

	private:
		int m_columns;
		std::vector<std::shared_ptr<option>> m_options;
	};
	``` This?

[DayibBaba]

Migrated to #36