List multi level #1181
List multi level #1181
Conversation
+ remove uneeded charset transformations
Consider all filter options as nodes (i.e. potentially as a tree) even if most of the time it will be flatten
Create new shared component folder
…o more prefix) The migration adjust existing form so the new identifier is the previously calculated one
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| resultimportlist.html(`<div class="alert alert-danger"> | ||
| ${listtranslations.notvalidurl} : ${url} | ||
| </div>`) |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
There was a problem hiding this comment.
i definitely prefer jquery and vanilla css transitions 🧓
|
|
||
| $listeId = $this->listManager->create($_POST['titre_liste'], $values); | ||
| if (isset($_POST['submit'])) { | ||
| $listeId = $this->listManager->create($_POST['title'], json_decode($_POST['nodes'], true)); |
There was a problem hiding this comment.
should we check if user has the rights to create a list ?
There was a problem hiding this comment.
the list creation is currently only disabled when wiki is "hibernated"
Do you want to change that? (the check is made in ListController->displayAll and ListManager->create
There was a problem hiding this comment.
if it's checked in the manager, it's ok, i suppose i just thought that COntroller should control :D
In any case, we can change it later, while opening to non admins users
| @@ -108,11 +108,11 @@ | |||
| </div> | |||
| <div class="form-group"> | |||
| <label>Latitude</label> | |||
| <input type="number" min="-90" max="90" v-model="latmodel" class="form-control"> | |||
| <input type="text" min="-90" max="90" v-model="latmodel" class="form-control"> | |||
There was a problem hiding this comment.
will the attributes min and max work on type="text"?
why change the type?
There was a problem hiding this comment.
quand j'ia testé chez moi, le input était invalide et montré comme tel (entouré de rouge) parce que la valeur fournie (en js j'imagine) est une string avec des virgules
Mais oui si on passe en text on peut enlever min et max, tu valides?
There was a problem hiding this comment.
oui c'est un détail, juste je suis curieux pourquoi il invalide? il lui fallait un value="" peut etre?
En tout cas c'est pas très important, fais comme ca t'arrange
Et voilà la grosse PR ! miam !
Elle inclut les deux changements que tu as déjà validé en parralèle (no more checkbocListList et petit refactor sur les assets de bazar). Désolé les commits sur le refacto des assets "pollue" pas mal la revue. Mais en gros faut surtout que tu regardes les classes php changées (EnumField, ListManager) et les nouveaux rendu twig
checkbox-tree.twigA priori le gros de la fonctionnalité est validé par les utilisateurs qui ont testés. Y'aura peut etre des correctifs mineurs et/ou améliorations en suivant
Bise !