Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update service_shard_update to deploy on environment #4026

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

panbenson
Copy link
Contributor

follow up for #3994

we should allow for deploys for certain environments, especially when using --iam-role because roles are often environment specific.
for backwards compatibility, this deploys to all environments when --environment is not passed in as an option.

@panbenson panbenson requested a review from a team as a code owner March 20, 2025 17:22
nemacysts
nemacysts previously approved these changes Mar 20, 2025
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the deploy_environments could probably be simplified a bit, but i won't nitpick too much since this script it owned by your team :p

nemacysts
nemacysts previously approved these changes Mar 20, 2025
@panbenson panbenson merged commit 0986e6b into master Mar 21, 2025
10 checks passed
@panbenson panbenson deleted the u/bpan/update-shard-by-env branch March 21, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants