cleanup for remote-run resources #4024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piax93
force-pushed
the
u/mpiano/SEC-19862_cleanup
branch
from
9da4711 to
a3d31a5
Compare
nemacysts
reviewed
Mar 19, 2025
| for entity in list_func(kube_client, namespace): | ||
| if ( | ||
| not entity.metadata.name.startswith("remote-run-") | ||
| or entity.metadata.creation_timestamp > age_limit |
There was a problem hiding this comment.
imo, we probably want to tag the resources with when they should be expired by - otherwise, we have to essentially always run this with --max-age $REMOTE_RUN_JOB_MAX_DURATION lest we delete an in-use SA/role/rolebinding
There was a problem hiding this comment.
We actually want to always delete these quickly. They should just exist for the user to be able to exec into the pod, once the shell session is established they can get removed.
There was a problem hiding this comment.
i guess there's not really an easy way for folks to exec back into the remote-run sandbox if their connection drops for whatever reason, so it does seem fine for this to happen :p
nemacysts
approved these changes
Mar 24, 2025
piax93
added a commit
that referenced
this pull request
Mar 25, 2025
Clean up logic for the (meant to be) ephemeral resources which are created in remote-run invocations (#4022).
nemacysts
pushed a commit
that referenced
this pull request
Mar 25, 2025
This was meant to be included in the last release but I (luisp) don't know how to read and merged things in the "wrong" order. This correctly merges in the following PRs: * cleanup for remote-run resources (#4024) Clean up logic for the (meant to be) ephemeral resources which are created in remote-run invocations (#4022). * new remote-run cli (#4025) Last portion of #3986, with the updated logic to reflect the updated API conventions introduced in #4022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up logic for the (meant to be) ephemeral resources which are created in remote-run invocations (#4022).