update iam-role to iam-role-mapping #4023
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
reviewed
Mar 20, 2025
Comment on lines
168
to
174
| parser.add_argument( | ||
| "--iam-role", | ||
| help="IAM role to use for the shard", | ||
| "--iam-role-mapping", | ||
| help="JSON string of deploy_prefix to IAM role mapping to use for the shard", | ||
| required=False, | ||
| type=str, | ||
| dest="iam_role", | ||
| dest="iam_role_mapping", | ||
| ) |
There was a problem hiding this comment.
you'll probably want to have both args exist temporarily - otherwise, there'll be a brief period of time where this is broken since either --iam-role or --iam-role-mapping won't exist in the deployed paasta package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up for #3994
iam roles typically differ between environments so using same
--iam-rolemay not always be valid.update this variable to
--iam-role-mappingso we can pass in a mapping from environment to role to account for this (e.g.{"dev": "some_role", "prod": "another_role"})