Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move auth tween below pyramid_swagger #4014

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

piax93
Copy link
Contributor

@piax93 piax93 commented Mar 3, 2025

The tween tries to access swagger_data, which won't be available before the swagger tween validated and loaded the request body, so it's currently failing.

I was undecided on whether to go this route, or trying to extract the "service" field from get/post data manually, but at the end I settled on moving the tween down the stack. This implementation does not include that many tweens, so I don't think not having auth right on top is going to be that impactful / dangerous.

@piax93 piax93 requested review from nemacysts and jfongatyelp March 3, 2025 16:59
@piax93 piax93 requested a review from a team as a code owner March 3, 2025 16:59

Verified

This commit was signed with the committer’s verified signature.
piax93 Matteo Piano
@piax93 piax93 force-pushed the u/mpiano/SEC-19859_fix_swagger_data branch from e7136db to 79cc51e Compare March 3, 2025 17:03
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume that we don't have a single place where we can control the tween ordering to add some comments about how we expect the tweens to be ordered

@nemacysts nemacysts merged commit 793ddf6 into master Mar 3, 2025
10 checks passed
@piax93
Copy link
Contributor Author

piax93 commented Mar 3, 2025

i assume that we don't have a single place where we can control the tween ordering to add some comments about how we expect the tweens to be ordered

@nemacysts each tween handles its positioning by itself, so not really.

@nemacysts
Copy link
Member

i assume that we don't have a single place where we can control the tween ordering to add some comments about how we expect the tweens to be ordered

each tween handles its positioning by itself, so not really.

unfortunate ;_;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants