Skip to content

Allow batches 30s of cleanup time on external kills #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/source/jobs.rst
Original file line number Diff line number Diff line change
@@ -395,6 +395,13 @@ AM).

Cleanup Actions
---------------
There are two possible approaches for cleanup that will depend on when you'd
like the cleanup to occur. You can either:
* Configure your code to cleanup on recieving a SIGTERM (NOTE: we have a
hardcoded limit of 30s before we send a SIGKILL and force-kill the action)
to handle cleanup whenever Tron or a human decides to tronctl kill a run
* OR, use a cleanup action as detailed below to handle cleanup after a job run
has completed.

Cleanup actions run after the job succeeds or fails. They are specified just
like regular actions except that there is only one per job and it has no name
2 changes: 1 addition & 1 deletion requirements-minimal.txt
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ pytimeparse
pytz
PyYAML>=5.1
requests
task_processing[mesos_executor,k8s]>=1.1.0
task_processing[mesos_executor,k8s]>=1.2.0
Twisted>=19.7.0
urllib3>=1.24.2
Werkzeug>=0.15.3
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ setuptools==65.5.1
six==1.15.0
sshpubkeys==3.1.0
stack-data==0.6.2
task-processing==1.1.0
task-processing==1.2.0
traitlets==5.0.0
Twisted==22.10.0
typing-extensions==4.5.0