Remove std library usage where possible #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename Value to FValue to match Unreal naming conventions. - Rename ValueType to EValueType to match Unreal naming conventions. - Utilize TVariant for core value storage in FValue. - Remove usage of std::string in FValue class. - Migrate GetXValue to templated GetValue function. - Utilize FString instead of std::string for string value in FValue class. - Add assignment operators to FValue class to simplify usage. - Create LexToString for EValueType. Remove deprecated FYarnValueHelpers.
codemaster
force-pushed
the
remove_std
branch
2 times, most recently
from
f7a89d9
to
e868311
Compare
- Deprecate & remove ILogger and string_format - Migrate function handlers to delegate definitions, per Unreal structures - Add [[maybe_unused]] to UnrealLogHandler to indicate the parameters may be unused - Update parameters to const reference where possible (function handlers, etc.) - Update map references to use Unreal's TMap, vector references to use Unreal's TArray - Implement State::ClearStack - Rename YarnFunction to TYarnFunction and migrate from std::function to TDelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on the existing pull request #3