use encoding.TextMarshaler if a value implements it #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use a type provided by 3rd party package. When the type does not implement neither graphql.Marshaler nor json.Marshaler, the result of MarshalJSON generates an unexpected string in some cases.
For example, assuming using github.com/google/uuid.uuid.UUID in a variable,
This is an example schema.
Bind the scalar to in gqlgenc.yaml
Then, gqlgenc generates a code to marshal a variable like this:
This generates a json value,
However, if we use json.Marshal directly instead of MarshalJSON, they generate different json values.
This is because json.Marshal's encoder supports encoding.TextMarshaler.
The description: https://cs.opensource.google/go/go/+/master:src/encoding/json/encode.go;l=32-40
The implementation: https://cs.opensource.google/go/go/+/master:src/encoding/json/encode.go;l=379-395
So I think it's better to respect encoding.TextMarshaler in MarshalJSON too. The current implementation of MarshalJSON calls json.Marshaler.MarshalJSON if a value implements json.Marshaler interface.