Fix: Use "rwt" file mode for the output image file #926
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #546
This PR fixes an issue with the output file size. No matter how low the compression quality is set the image will remain its original file size after cropping.
The default file mode used when opening the
OutputStream
for themImageOutputUri
seems to be the culprit. Changing it towt
fixed the issue.Testing:
Use the sample app and first check the
develop-non-native
branch.Tmp file destination
Resize image to max size
- set it to a low value like 500pick & crop
Device Explorer
in Android Studio and go todata/data/com.yalantis.ucrop.sample/cache
SampleCropImage.jpg
- compare it with the originalNow check out this branch and repeat the steps above.