fix(runtime): add ability to ignore setmode failure

YakshaLang · Mar 29, 2024 · 62f321f · 62f321f
1 parent c5dd614
commit 62f321f
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 6 deletions.
diff --git a/compiler/runtime/README.md b/compiler/runtime/README.md
@@ -19,6 +19,9 @@ Bunch of `C` code that standard library depend on.
 | `cr.h`          | Danny Angelo Carminati Grein        | hot reloading capabilities         | [cr.h](https://github.com/fungos/cr)                      | MIT                                                                                    |
 | `endianness.h`  | rofl0r                              | endian conversion                  | [endianness.h](https://github.com/rofl0r/endianness.h)    | MIT/PublicDomain                                                                       |
 
+
+* Warn! net libraries need to be wrapped. They are not used yet.
+
 ### Patches
 
 * argparse - `const char short_name;` was changed to `char short_name;`

diff --git a/compiler/runtime/_include_mman_win.c b/compiler/runtime/_include_mman_win.c
@@ -1,3 +1,9 @@
+// Below code is originally from mman-win32
+//
+/*
+ * sys/mman.h
+ * mman-win32
+ */
 #include <errno.h>
 #include <io.h>
 #ifndef FILE_MAP_EXECUTE

diff --git a/compiler/runtime/_include_mman_win.h b/compiler/runtime/_include_mman_win.h
@@ -1,3 +1,9 @@
+// Below code is originally from mman-win32
+//
+/*
+ * sys/mman.h
+ * mman-win32
+ */
 #include <time.h>
 #include <sys/types.h>
 #include <stdint.h>

diff --git a/compiler/runtime/yk__main.c b/compiler/runtime/yk__main.c
@@ -18,7 +18,12 @@ int main(int argc, char *argv[]) {
 #if defined(_WIN32) || defined(_WIN64)
   int result_mode;
   result_mode = _setmode(_fileno(stdout), _O_U16TEXT);
+#if !defined(YK_IGNORE_WINDOWS_CONSOLE_SET_MODE_ERROR)
+  // If we can't set the mode, return -1
+  //   only a concern for a console application
+  //   otherwise, we can ignore this error and let things continue as is
   if (result_mode == -1) { return -1; }
+#endif
 #if defined(YK__WINDOWS_HIDE_CONSOLE)
   ShowWindow(GetConsoleWindow(), SW_HIDE);
   FreeConsole();

diff --git a/compiler/runtime/yk__system.c b/compiler/runtime/yk__system.c
@@ -15,12 +15,6 @@
 #ifndef ssize_t
 #define ssize_t intmax_t
 #endif
-// Below code is originally from mman-win32
-//
-/*
- * sys/mman.h
- * mman-win32
- */
 #ifndef _WIN32_WINNT// Allow use of features specific to Windows XP or later.
 #define _WIN32_WINNT                                                           \
   0x0501// Change this to the appropriate value to target other versions of Windows.