Randomize firstCheckTime into the future, rather than scheduling in the past #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I remember correctly, the intent of using a past timestamp was to ensure that the first update check would happen as soon as possible, and all future checks would happen with a randomized offset. See #323 for some relevant discussion. By using a positive offset, we would lose that first, immediate check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently a random offset is subtracted from time() and scheduled (such that the event is scheduled in the past, causing the job to execute on each WP-Cron execution since the scheduled time has passed). PR changes this to schedule the next update cycle at a randomized time in the future.