Add "Advanced Statistics" section to Scorecard#307
Draft
ShawnHardwick wants to merge 1 commit intoYARC-Official:masterfrom
Draft
Add "Advanced Statistics" section to Scorecard#307ShawnHardwick wants to merge 1 commit intoYARC-Official:masterfrom
ShawnHardwick wants to merge 1 commit intoYARC-Official:masterfrom
Conversation
6087e7f to
42f6b7f
Compare
0d7d610 to
ff52254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding YARG PR: YARC-Official/YARG#1222
Props to #302 for some inspiration.
This PR implements a new section on the scorecard that details:
This new Advanced Statistics section and the calculations handled for OnNoteHit are disabled by default and can be enabled with the "Enable Advanced Statistics on Scorecard" option under Experimental. Feel free to move this to whatever section you'd like.
Score judgement can also be customized as part of the Engine presets.

Limitations/caveats: