Addressing two more convtranspose usecases #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorickert
reviewed
Mar 11, 2025
| @@ -763,6 +767,16 @@ bool ShouldDecomposeConvTransposeOpToPhasedConvs(Value convTransposeResult, | |||
| padsShape == SmallVector<int64_t>{1, 1, 0, 0}) | |||
| return true; | |||
| } | |||
| // Supports only with padding [0, 0, 0, 0] | |||
There was a problem hiding this comment.
I am wondering if we can generalize this instead of hardcoding specific paddings and kernels
There was a problem hiding this comment.
If the padding is of convT is changed to [ 1, 1, 1, 1], the conv outputs of conv2 get top and left garbage, requiring the slice. We have to handle the change in padding with a different decomposition.
If convT has [2,2,2,2] padding, the decomposition deviates both from [1,1,1,1] and [0,0,0,0]
Co-authored-by: Jonas Rickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing below usecases